Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub: convert iam to use gax #2744

Merged
merged 4 commits into from
Nov 16, 2017
Merged

pubsub: convert iam to use gax #2744

merged 4 commits into from
Nov 16, 2017
+127 −117

Conversation

callmehiphop
Copy link
Contributor

Relates to #2699

@callmehiphop callmehiphop added the api: pubsub Issues related to the Pub/Sub API. label Nov 14, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 14, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 876d5b6 on callmehiphop:dg--pubsub-gax-iam into 25af76e on GoogleCloudPlatform:master.

stephenplusplus
stephenplusplus reviewed Nov 15, 2017
View reviewed changes
packages/pubsub/src/iam.js Outdated
/**
* Get the IAM policy
*
* @param {object=} gaxOpts - Request configuration options, outlined

This comment was marked as spam.

Sign in to view

packages/pubsub/system-test/pubsub.js
@@ -513,7 +513,6 @@ describe('pubsub', function() {
assert.ifError(err);

assert.deepEqual(policy.bindings, []);
assert.strictEqual(policy.etag, 'ACAB');

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d02d2ba on callmehiphop:dg--pubsub-gax-iam into 25af76e on GoogleCloudPlatform:master.

@callmehiphop
Copy link
Contributor Author

/bump @stephenplusplus

@stephenplusplus stephenplusplus merged commit 2203209 into googleapis:master Nov 16, 2017
@stephenplusplus stephenplusplus removed the cla: yes This human has signed the Contributor License Agreement. label Nov 16, 2017
@renovate renovate bot mentioned this pull request Feb 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenplusplus stephenplusplus stephenplusplus left review comments

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@callmehiphop @coveralls @stephenplusplus @googlebot